[CodeCompletion] Fast completion inside function builder function #32946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PreCheckFunctionBuilderRequest` applies `PreCheckExpression` to the expressions inside the function body. Previously it used to receive only `AnyFunctionRef` (`FunctionDecl` or `ClosureExpr`) as the parameter. However, when fast-completion kicks-in, it replaces the body of the function, then tries to call `PreCheckFunctionBuilderRequest` again, with the same function decl as before. It used to return cached "Success" result, but it didn't actually apply `PreCheckExpression`. So any `UnresolvedDeclRefExpr` remained unresolved. In this patch, make `PreCheckFunctionBuilderRequest` receive "body" of the function as well, so it doesn't return the cached result for the *previous* body. rdar://problem/65692922
|
@swift-ci Please smoke test |
|
@CodaFi Is there a better way to differentiate request evaluator keys, for example, manually creating the key from the arguments inside the request? |
|
When we need to create custom keys, I've taken to using the |
CodaFi
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreCheckFunctionBuilderRequestappliesPreCheckExpressionto the expressions inside the function body. Previously it used to receive onlyAnyFunctionRef(FunctionDeclorClosureExpr) as the parameter. However, when fast-completion kicks-in, it replaces the body of the function, then tries to callPreCheckFunctionBuilderRequestagain, with the same function decl as before. It used to return cached "Success" result, but it didn't actually applyPreCheckExpression. So anyUnresolvedDeclRefExprremained unresolved.In this patch, make
PreCheckFunctionBuilderRequestreceive "body" of the function as well, so it doesn't return the cached result for the previous body.rdar://problem/65692922